Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to poll privacy_request for completion #1860

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Nov 28, 2022

Closes #1749

Code Changes

  • Added httpx as a dependency in order to preform async requests.
  • Added a poll_server_for_completion function to poll for completion.

Steps to Confirm

  • Verify that the function return with the correct status on privacy requests. More through testing will be possible once the connector for child servers is in place.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@adamsachs adamsachs mentioned this pull request Nov 28, 2022
6 tasks
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor tweaks, otherwise this is looking great!

for traceability - we'll incorporate the changes into https://github.com/ethyca/fides/pull/1861/files

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me now @sanders41 , thanks for the quick updates based on my comments!

@sanders41 sanders41 merged commit 6b2550b into main Nov 29, 2022
@sanders41 sanders41 deleted the ps-poll-child branch November 29, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ability to Fides Connector to poll for status of privacy request execution
2 participants