Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates docs to reflect configs necessary for mailgun, twilio_sms and twilio_email service types #1846

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Updates docs to reflect configs necessary for mailgun, twilio_sms and twilio_email service types #1846

merged 3 commits into from
Nov 23, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Nov 23, 2022 •
edited
Loading

Closes 1559

Code Changes

  • Update docs
  • Adds FIDES__NOTIFICATIONS__NOTIFICATION_SERVICE_TYPE to example.env

Steps to Confirm

  • nox -s docs_serve

Screenshot of updated messaging docs:

screencapture-0-0-0-0-8000-fides-guides-messaging-2022-11-22-18_05_52

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@eastandwestwind eastandwestwind requested a review from a team November 23, 2022 00:13
@eastandwestwind eastandwestwind force-pushed the 1559-update-messaging-docs branch from efdbe5b to c89ce14 Compare November 23, 2022 15:48
@eastandwestwind eastandwestwind merged commit d84e2e2 into main Nov 23, 2022
@eastandwestwind eastandwestwind deleted the 1559-update-messaging-docs branch November 23, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conceptualshark conceptualshark conceptualshark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for SMS Based Privacy Requests
2 participants
@eastandwestwind @conceptualshark