Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Erasure Policy for Complete Mask #1839

Merged
merged 11 commits into from
Dec 20, 2022
Merged

New Erasure Policy for Complete Mask #1839

merged 11 commits into from
Dec 20, 2022

Conversation

sadaqatullah
Copy link
Contributor

@sadaqatullah sadaqatullah commented Nov 22, 2022 •
edited
Loading

Closes #1839

Code Changes

  • Adds a new Erasure Policy that Masks common user data in SaaS connectors.

Steps to Confirm

  • When using any other erasure policy, system just masks first_name and last_name. This new erasure policy called erasure_policy_complete_mask masks most of the known data from SaaS connectors.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Update CHANGELOG.md

Description Of Changes

This PR adds a new erasure policy that aims to erase as much data possible from based on previously built SaaS connectors.

@sadaqatullah sadaqatullah linked an issue Nov 22, 2022 that may be closed by this pull request
Create New Policy for Erasure #1820
Closed
@sadaqatullah sadaqatullah requested a review from galvana November 22, 2022 15:10
@galvana galvana changed the title Finalized Code Changes More complete masking policy for SaaS connector tests Nov 28, 2022
galvana
galvana reviewed Nov 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sadaqatullah sadaqatullah changed the title More complete masking policy for SaaS connector tests New Erasure Policy for Mask Nov 30, 2022
@sadaqatullah sadaqatullah changed the title New Erasure Policy for Mask New Erasure Policy for Complete Mask Dec 6, 2022
@sadaqatullah sadaqatullah force-pushed the 1820-create-new-policy-for-erasure branch from eee7834 to 796c31a Compare December 19, 2022 17:11
galvana
galvana approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the initiative to make this addition to our testing suite, this will be very useful! I'm still not sure about some of the masking values we've chosen here but we can always adjust as need

@galvana galvana merged commit 7aec9b5 into main Dec 20, 2022
@galvana galvana deleted the 1820-create-new-policy-for-erasure branch December 20, 2022 00:44
@cypress Cypress
Copy link

cypress bot commented Feb 5, 2025 •
edited
Loading

fides    Run #12325

Run Properties:  status check passed Passed #12325  •  git commit e308f197ff ℹ️: Merge 88246717e764d2e4bc6085c24c41e04f6c8862c9 into 732652946b3b0ad13fb64ef5bf29...
Project fides
Branch Review HA-147
Run status status check passed Passed #12325
Run duration 00m 50s
Commit git commit e308f197ff ℹ️: Merge 88246717e764d2e4bc6085c24c41e04f6c8862c9 into 732652946b3b0ad13fb64ef5bf29...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Feb 11, 2025

fides    Run #12327

Run Properties:  status check passed Passed #12327  •  git commit 1a67af45a3: HA-147 - Add endpoint to manually trigger datahub sync (#1839)
Project fides
Branch Review main
Run status status check passed Passed #12327
Run duration 00m 49s
Commit git commit 1a67af45a3: HA-147 - Add endpoint to manually trigger datahub sync (#1839)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create New Policy for Erasure
2 participants
@sadaqatullah @galvana