Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1193 saas connector fullstory #1821

Merged
merged 6 commits into from
Nov 22, 2022
Merged

1193 saas connector fullstory #1821

merged 6 commits into from
Nov 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2022 •
edited by ghost
Loading

Purpose

  • Purpose of this PR is to add FUllstory connector access and erasure endpoints

Changes

  • Added config for Fullstory Access and Erasure Endpoints
  • Added related dataset and configuration
  • Added associated tests to validate above functionality

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1823

@ghost ghost requested review from galvana and a team November 18, 2022 15:15
@ghost ghost linked an issue Nov 18, 2022 that may be closed by this pull request
Fullstory #1823
Closed
@galvana galvana removed the request for review from a team November 22, 2022 21:52
galvana
galvana approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here, this was very easy to review 👍

@galvana galvana merged commit 0045404 into main Nov 22, 2022
@galvana galvana deleted the 1193-saas-connector-fullstory branch November 22, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullstory
1 participant
@galvana