ui/auth: Remove lingering local storage parsing #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssangervasi
commented
Nov 3, 2022
chriscalhoun1974
approved these changes
Nov 3, 2022
I was wondering why we need to manually open up localStorage when we have redux-persist configured to do that for us now. Removed this and the log in/out still works as expected. So I think this was just a lingering from changeover. Similar to this block that was left over from the fidesops merge: https://github.com/ethyca/fides/pull/1569/files#diff-3071c1012e5bece4441d5b7643c083188c22fbfe96caea78da1f09fdeeeb1599L59
ssangervasi
force-pushed
the
ssangervasi/auth-store-cleanup
branch
from
6bbde2b
to
6e58f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
I was wondering why we need to manually open up localStorage when we have redux-persist configured to do that for us now. Removed this and the log in/out still works as expected. So I think this was just a lingering from changeover.
Similar to this block that was left over from the fidesops merge: https://github.com/ethyca/fides/pull/1569/files#diff-3071c1012e5bece4441d5b7643c083188c22fbfe96caea78da1f09fdeeeb1599L59