Restore: [1480] ui/auth: Query current user permissions to detect stale token #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidesops PR 1409 replaced the original credential storage with the redux-persist logic. The credential storage lines got reintroduced by a merge: https://github.com/ethyca/fidesops/pull/1409/files#diff-af758411de81fed87d14012809b227b11c67ce770c998fd5059ea0769fbb5bd4L59 Unclear if this has caused any problems. My guess is that it's just been adding an unused key to localStorage.
Kelsey-Ethyca
deleted the
ssangervasi/fides-1480/expired-client-storage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore #1569
There is a bug now where root_user cannot access the app and a test skipped that needs to be restored.