Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1434 saas connector twilio conversation access #1520

Merged
merged 14 commits into from
Nov 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 21, 2022

Purpose

  • Purpose of this PR is to add Twilio connector Conversation access endpoints

Changes

  • Added config for Twilio Conversation Access Endpoints
  • Added related dataset and configuration
  • Added associated tests to validate above functionality

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1521

@ghost ghost requested a review from galvana October 21, 2022 21:22
@ghost ghost force-pushed the 1434-saas-connector-twilio-conversation-access branch from 188799b to e00875b Compare October 26, 2022 17:20
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to being done, just need to add pagination to the endpoints that may contain more pages of data and add user data categories to the appropriate fields.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the recommended changes, this looks good to me!

@galvana galvana merged commit 829b941 into main Nov 2, 2022
@galvana galvana deleted the 1434-saas-connector-twilio-conversation-access branch November 2, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twilio (conversation) - Access
1 participant