Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files from /clients/ops/privacy-center to /clients/privacy-center #1372

Merged
merged 3 commits into from
Oct 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/dependabot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ updates:
- python
- dependabot
- package-ecosystem: npm
directory: "/clients/ops/admin-ui"
directory: "/clients/admin-ui"
schedule:
interval: weekly
labels:
- dependencies
- javascript
- dependabot
- package-ecosystem: npm
directory: "/clients/ops/privacy-center"
directory: "/clients/privacy-center"
schedule:
interval: weekly
labels:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/frontend_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
node-version: [16.x]
defaults:
run:
working-directory: clients/ops/privacy-center
working-directory: clients/privacy-center
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_privacy_center_to_dockerhub.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Build and publish
uses: docker/build-push-action@v3
with:
context: ./clients/ops/privacy-center
context: ./clients/privacy-center
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.metadata.outputs.labels }}
4 changes: 2 additions & 2 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
"request": "launch",
"type": "chrome",
"url": "http://localhost:3000",
"webRoot": "${workspaceFolder}/clients/ops/admin-ui"
"webRoot": "${workspaceFolder}/clients/admin-ui"
},
{
"name": "Attach to Chrome",
"port": 9222,
"request": "attach",
"type": "chrome",
"urlFilter": "http://localhost:3000/*", // use urlFilter instead of url!
"webRoot": "${workspaceFolder}/clients/ops/admin-ui"
"webRoot": "${workspaceFolder}/clients/admin-ui"
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Admin UI for managing Fides privacy requests. A web application built in Next.js
## Running Locally

1. Run `nox -s create_user` and follow prompts to create a user. Note that password requires 8 or more characters, upper and lowercase chars, a number, and a symbol.
2. In a new shell, `cd` into `clients/ops/admin-ui`, then run `npm run dev`.
2. In a new shell, `cd` into `clients/admin-ui`, then run `npm run dev`.
3. Nav to `http://localhost:3000/` and logged in using created user. The `email` field is simply the `user` that was created, not a valid email address.

## Testing Entire Request Flow
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Adapted from https://github.com/ethyca/fides/blob/main/clients/ops/admin-ui/src/features/common/form/inputs.tsx
// Adapted from https://github.com/ethyca/fides/blob/main/clients/admin-ui/src/features/common/form/inputs.tsx
// Should in the future consider pulling this into fidesui

import {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ services:
- "3001:3000"
volumes:
- type: bind
source: ./clients/ops/privacy-center/config
source: ./clients/privacy-center/config
target: /app/config
read_only: False

Expand Down
4 changes: 2 additions & 2 deletions docs/fides/docs/development/ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ additional [user endpoints](#managing-users).
From the root `fidesops` directory, run the following:

``` sh
cd clients/ops/admin-ui
cd clients/admin-ui
npm install
npm run dev
```
Expand All @@ -43,7 +43,7 @@ Fidesops automatically serves a version of the UI when running `nox -s dev`.
To deploy a full version of the UI from a backend, run the following from the root fidesops directory:

```sh
cd clients/ops/admin-ui
cd clients/admin-ui
npm install
npm run prod-export
```
Expand Down
2 changes: 1 addition & 1 deletion noxfiles/docker_nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def build(session: nox.Session, image: str) -> None:
session.run(
"docker",
"build",
"clients/ops/privacy-center",
"clients/privacy-center",
"--tag",
"ethyca/fides-privacy-center:local",
external=True,
Expand Down