Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disabled Nav Buttons #1067

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Remove disabled Nav Buttons #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5304d08
Update NavBar.tsx
ThomasLaPiana Sep 12, 2022
d32b5eb
remove "more" from the navbar
ThomasLaPiana Sep 12, 2022
338d989
fix a linting error
ThomasLaPiana Sep 12, 2022
7c65c60
remove cypress tests for disabled links
ThomasLaPiana Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions clients/ctl/admin-ui/cypress/e2e/nav-bar.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ describe("Nav Bar", () => {
cy.getByTestId("nav-link-Taxonomy");
cy.getByTestId("nav-link-Systems");

// Disabled links

cy.getByTestId("nav-link-Policies").should("have.attr", "disabled");
cy.getByTestId("nav-link-User Management").should("have.attr", "disabled");
cy.getByTestId("nav-link-More").should("have.attr", "disabled");
});

it("Renders the active page based on the current route", () => {
Expand Down
9 changes: 0 additions & 9 deletions clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import dynamic from "next/dynamic";
import React from "react";

import { useFeatures } from "~/features/common/features.slice";
import { ArrowDownLineIcon } from "~/features/common/Icon";

// Cross-zone navigation requires building URLs from the current `window.location`
// which is not available in Server-Side-Rendered components.
Expand All @@ -27,17 +26,9 @@ const NavBar = () => {
{/* Links under the datamap zone: */}
{features.plus ? <NavLink title="Data Map" href="/datamap" /> : null}

<NavLink title="Policies" href="/policy" disabled />
<NavLink title="Taxonomy" href="/taxonomy" />
<NavLink title="User Management" href="/user-management" disabled />
{/* This is a temporary link to the config wizard while it's still in progress */}
<NavLink title="Config Wizard" href="/config-wizard" />
<NavLink
title="More"
href="#"
rightIcon={<ArrowDownLineIcon />}
disabled
/>
</nav>
</Flex>
);
Expand Down