Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braze requires email to formatted correctly, connector fails on erasure #4179

Closed
SteveDMurphy opened this issue Sep 28, 2023 · 1 comment · Fixed by #4187 or #4196
Closed

Braze requires email to formatted correctly, connector fails on erasure #4179

SteveDMurphy opened this issue Sep 28, 2023 · 1 comment · Fixed by #4187 or #4196
Assignees
Labels
bug Something isn't working

Comments

@SteveDMurphy
Copy link
Contributor

Bug Description

The Braze connector requires email to be formatted like an email (i.e. [email protected])

We currently use the default masked string for this connector, resulting in a 400 error

We should format the masked string to look like a valid email

Steps to Reproduce

This requires a valid Braze account with a known email
Try to update the email of a user to a random string
See the error response

Expected behavior

The data should be masked appropriately

Screenshots

{
    "message": "Valid data must be provided in the 'attributes', 'events', or 'purchases' fields.",
    "errors": [
        {
            "type": "The value provided for the 'email' field is not a valid email.",
            "input_array": "attributes",
            "index": 0
        }
    ]
}

Environment

  • Version: 2.20.2
  • OS: Darwin
  • Python Version: 3.10
  • Docker Version:

Additional context

Found when troubleshooting a connector issue, it looks like we do something similar already for Domo -> https://github.com/ethyca/fides/blob/main/src/fides/api/service/saas_request/override_implementations/domo_request_overrides.py#L36-L37

This could be nice if we had a general fides_meta attribute to select from a required masked format (i.e. email, phone, etc.)

@SteveDMurphy SteveDMurphy added the bug Something isn't working label Sep 28, 2023
@SteveDMurphy
Copy link
Contributor Author

@galvana I am going to take a stab at a quick fix here for Braze but wanted to tag you for visibility (as well about a longer term solution maybe?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant