Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braze Override for Email #4187

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Braze Override for Email #4187

merged 4 commits into from
Sep 29, 2023

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Sep 28, 2023

Partially Closes #4179

Description Of Changes

Found in a recent test, unclear if this is a recent change by Braze

This creates an override that allows Braze to mask email with a proper format to meet the needs of Braze.

Code Changes

  • Create an override for Braze
  • Update config to use override
  • Update dataset to prefer the braze_id over an external_id

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

When both an external_id and a braze_id are passed, the API will return a 400 due to the dueling IDs
@cypress
Copy link

cypress bot commented Sep 28, 2023

Passing run #4403 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge d7dcca7 into 92fd45b...
Project: fides Commit: 274296c6e8 ℹ️
Status: Passed Duration: 00:49 💡
Started: Sep 29, 2023 12:40 AM Ended: Sep 29, 2023 12:41 AM

Review all test suite changes for PR #4187 ↗︎

@galvana galvana marked this pull request as ready for review September 29, 2023 00:29
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks gang!

@galvana galvana merged commit f69284c into main Sep 29, 2023
34 of 37 checks passed
@galvana galvana deleted the SteveDMurphy-braze-4179-email branch September 29, 2023 01:28
SteveDMurphy added a commit that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Braze requires email to formatted correctly, connector fails on erasure
3 participants