Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish privacy center forms #2269

Closed
allisonking opened this issue Jan 18, 2023 · 1 comment
Closed

Polish privacy center forms #2269

allisonking opened this issue Jan 18, 2023 · 1 comment

Comments

@allisonking
Copy link
Contributor

Is your feature request related to a specific problem?

There are some parts of the privacy center forms that we could polish up.

Describe the solution you'd like

  • Using chakra's isRequired prop (context) instead of our own asterisk
  • Use formik's isLoading instead of setting our own state
  • Standardize form inputs into their own components instead of copy/pasta-ing. Perhaps we can even pull the entire identity input form into its own component that takes the configured identity inputs

Describe alternatives you've considered, if any

None of these are required, but will make things nicer

Additional context

Add any other context or screenshots about the feature request here.

@allisonking
Copy link
Contributor Author

#2379 handles the isRequired prop 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants