Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make identity_inputs optional #2263

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jan 17, 2023

Closes #2259

Code Changes

  • Makes identity inputs optional in typescript
  • Uses email as a default when no identity inputs are provided

Steps to Confirm

  • Start up nox -s test_env. The privacy center should come up without problem, despite the test env's config not having identity inputs. Clicking on "manage your consent" should show only an email field.
  • Editing the identity_inputs field on either actions or consent options should show the fields as you set them (note the test env's privacy center will not hot reload though—it's easiest to test this just with npm run dev, or to nox -s "build(privacy-center)" and then docker-compose up fides-pc --no-deps fides-pc

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking marked this pull request as ready for review January 17, 2023 23:07
Co-authored-by: Robert Keyser <[email protected]>
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@allisonking
Copy link
Contributor Author

The failing test is unrelated to this PR (it's happening in other PRs too 😕 )

@allisonking allisonking merged commit 2d0cfdd into main Jan 18, 2023
@allisonking allisonking deleted the aking/2259/privacy-center-config-fixup branch January 18, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy center config identity inputs should be optional
3 participants