ui/taxonomy: Remove identifiablity (data qualifier) editor (#2684)

ethyca · Feb 23, 2023 · 72b5dfe · 72b5dfe
1 parent 3534314
commit 72b5dfe
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 83 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -33,19 +33,15 @@ The types of changes are:
 
 * Set the security environment of the fides dev setup to `prod` instead of `dev` [#2588](https://github.com/ethyca/fides/pull/2588)
 * Removed unexpected default Redis password [#2666](https://github.com/ethyca/fides/pull/2666)
-
-### Fixed
-
-* Fix support for "redis.user" setting when authenticating to the Redis cache [#2666](https://github.com/ethyca/fides/pull/2666)
-
-### Developer Experience
-
 * Privacy Center
   * Typechecking and validation of the `config.json` will be checked for backwards-compatibility. [#2661](https://github.com/ethyca/fides/pull/2661)
 
 ### Fixed
 
+* Fix support for "redis.user" setting when authenticating to the Redis cache [#2666](https://github.com/ethyca/fides/pull/2666)
 * Fix error with the classify dataset feature flag not writing the dataset to the server [#2675](https://github.com/ethyca/fides/pull/2675)
+* Admin UI
+  * Remove Identifiability (Data Qualifier) from taxonomy editor [2684](https://github.com/ethyca/fides/pull/2684)
 
 ## [2.7.0](https://github.com/ethyca/fides/compare/2.6.6...2.7.0)
 

diff --git a/clients/admin-ui/cypress/e2e/taxonomy.cy.ts b/clients/admin-ui/cypress/e2e/taxonomy.cy.ts
@@ -14,7 +14,6 @@ describe("Taxonomy management page", () => {
     cy.getByTestId("tab-Data Categories");
     cy.getByTestId("tab-Data Uses");
     cy.getByTestId("tab-Data Subjects");
-    cy.getByTestId("tab-Identifiability");
   });
 
   describe("Can view data", () => {
@@ -26,8 +25,6 @@ describe("Taxonomy management page", () => {
       cy.wait("@getDataUses");
       cy.getByTestId("tab-Data Subjects").click();
       cy.wait("@getDataSubjects");
-      cy.getByTestId("tab-Identifiability").click();
-      cy.wait("@getDataQualifiers");
       cy.getByTestId("tab-Data Categories").click();
       cy.wait("@getDataCategories");
     });
@@ -123,16 +120,6 @@ describe("Taxonomy management page", () => {
           isParent: false,
           request: "@putDataSubject",
         },
-        {
-          tab: "Identifiability",
-          name: "Aggregated Data",
-          key: "aggregated",
-          description:
-            "Statistical data that does not contain individually identifying information but includes information about groups of individuals that renders individual identification impossible.",
-          parentKey: "",
-          isParent: true,
-          request: "@putDataQualifier",
-        },
       ];
       expectedTabValues.forEach((tabValue) => {
         cy.getByTestId(`tab-${tabValue.tab}`).click();
@@ -367,11 +354,6 @@ describe("Taxonomy management page", () => {
           name: "Data subject",
           request: "@postDataSubject",
         },
-        {
-          tab: "Identifiability",
-          name: "Data qualifier",
-          request: "@postDataQualifier",
-        },
       ];
       expectedTabValues.forEach((tabValue) => {
         cy.getByTestId(`tab-${tabValue.tab}`).click();
@@ -510,7 +492,6 @@ describe("Taxonomy management page", () => {
       const tabValues = [
         { tab: "Data Categories", request: "@deleteDataCategory" },
         { tab: "Data Uses", request: "@deleteDataUse" },
-        { tab: "Identifiability", request: "@deleteDataQualifier" },
       ];
       tabValues.forEach((tabValue) => {
         cy.getByTestId(`tab-${tabValue.tab}`).click();

diff --git a/clients/admin-ui/src/features/taxonomy/TaxonomyTabs.tsx b/clients/admin-ui/src/features/taxonomy/TaxonomyTabs.tsx
@@ -3,12 +3,7 @@ import { Box, Button } from "@fidesui/react";
 import { useAppDispatch } from "~/app/hooks";
 
 import DataTabs, { TabData } from "../common/DataTabs";
-import {
-  useDataCategory,
-  useDataQualifier,
-  useDataSubject,
-  useDataUse,
-} from "./hooks";
+import { useDataCategory, useDataSubject, useDataUse } from "./hooks";
 import { setIsAddFormOpen } from "./taxonomy.slice";
 import TaxonomyTabContent from "./TaxonomyTabContent";
 
@@ -25,10 +20,6 @@ const TABS: TabData[] = [
     label: "Data Subjects",
     content: <TaxonomyTabContent useTaxonomy={useDataSubject} />,
   },
-  {
-    label: "Identifiability",
-    content: <TaxonomyTabContent useTaxonomy={useDataQualifier} />,
-  },
 ];
 const TaxonomyTabs = () => {
   const dispatch = useAppDispatch();

diff --git a/clients/admin-ui/src/features/taxonomy/hooks.tsx b/clients/admin-ui/src/features/taxonomy/hooks.tsx
@@ -5,7 +5,6 @@ import { useCustomFields } from "~/features/common/custom-fields/hooks";
 import { RTKResult } from "~/features/common/types";
 import {
   DataCategory,
-  DataQualifier,
   DataSubject,
   DataSubjectRightsEnum,
   DataUse,
@@ -23,12 +22,6 @@ import {
   CustomTextInput,
 } from "../common/form/inputs";
 import { enumToOptions } from "../common/helpers";
-import {
-  useCreateDataQualifierMutation,
-  useDeleteDataQualifierMutation,
-  useGetAllDataQualifiersQuery,
-  useUpdateDataQualifierMutation,
-} from "../data-qualifier/data-qualifier.slice";
 import {
   useCreateDataSubjectMutation,
   useDeleteDataSubjectMutation,
@@ -468,43 +461,3 @@ export const useDataSubject = (): TaxonomyHookData<DataSubject> => {
     transformEntityToInitialValues,
   };
 };
-
-export const useDataQualifier = (): TaxonomyHookData<DataQualifier> => {
-  const { data, isLoading } = useGetAllDataQualifiersQuery();
-  const [entityToEdit, setEntityToEdit] = useState<DataQualifier | null>(null);
-
-  const labels = {
-    fides_key: "Data qualifier",
-    name: "Data qualifier name",
-    description: "Data qualifier description",
-    parent_key: "Parent data qualifier",
-  };
-
-  const [createDataQualifierMutationTrigger] = useCreateDataQualifierMutation();
-  const [updateDataQualifierMutationTrigger] = useUpdateDataQualifierMutation();
-  const [deleteDataQualifierMutationTrigger] = useDeleteDataQualifierMutation();
-
-  const handleCreate = (initialValues: FormValues, newValues: FormValues) =>
-    createDataQualifierMutationTrigger(
-      transformBaseFormValuesToEntity(initialValues, newValues)
-    );
-
-  const handleEdit = (initialValues: FormValues, newValues: FormValues) =>
-    updateDataQualifierMutationTrigger(
-      transformBaseFormValuesToEntity(initialValues, newValues)
-    );
-
-  const handleDelete = deleteDataQualifierMutationTrigger;
-
-  return {
-    data,
-    isLoading,
-    labels,
-    entityToEdit,
-    setEntityToEdit,
-    handleCreate,
-    handleEdit,
-    handleDelete,
-    transformEntityToInitialValues: transformTaxonomyBaseToInitialValues,
-  };
-};