move GPC preferences before we send fidesInitialized event (#3561)

CHANGELOG.md

@@ -19,10 +19,14 @@ The types of changes are:
 
 ### Added
 - Empty state for when there are no relevant privacy notices in the privacy center [#3640](https://github.com/ethyca/fides/pull/3640)
-### Fixed
 
+### Fixed
 - Render linebreaks in the Fides.js overlay descriptions, etc. [#3665](https://github.com/ethyca/fides/pull/3665)
 
+### Changed
+- Moved GPC preferences slightly earlier in Fides.js lifecycle [#3561](https://github.com/ethyca/fides/pull/3561)
+
+
 ## [2.15.0](https://github.com/ethyca/fides/compare/2.14.1...2.15.0)
 
 ### Added

clients/fides-js/src/fides.ts

@@ -196,8 +196,8 @@ const init = async ({
     _Fides.geolocation = geolocation;
     _Fides.options = options;
     _Fides.initialized = true;
-    dispatchFidesEvent("FidesInitialized", cookie);
-    dispatchFidesEvent("FidesUpdated", cookie);
+    dispatchFidesEvent("FidesInitialized", cookie, options.debug);
+    dispatchFidesEvent("FidesUpdated", cookie, options.debug);
   }
 
   let shouldInitOverlay: boolean = options.isOverlayEnabled;
@@ -255,6 +255,14 @@ const init = async ({
       }
     }
   }
+  if (shouldInitOverlay) {
+    automaticallyApplyGPCPreferences(
+      cookie,
+      fidesRegionString,
+      options.fidesApiUrl,
+      effectiveExperience
+    );
+  }
 
   // Initialize the window.Fides object
   _Fides.consent = cookie.consent;
@@ -270,18 +278,9 @@ const init = async ({
   // For convenience, also dispatch the "FidesUpdated" event; this allows
   // listeners to ignore the initialization event if they prefer
   if (!hasExistingCookie) {
-    dispatchFidesEvent("FidesInitialized", cookie);
-  }
-  dispatchFidesEvent("FidesUpdated", cookie);
-
-  if (shouldInitOverlay) {
-    automaticallyApplyGPCPreferences(
-      cookie,
-      fidesRegionString,
-      options.fidesApiUrl,
-      effectiveExperience
-    );
+    dispatchFidesEvent("FidesInitialized", cookie, options.debug);
   }
+  dispatchFidesEvent("FidesUpdated", cookie, options.debug);
 };
 
 // The global Fides object; this is bound to window.Fides if available

clients/fides-js/src/lib/events.ts

@@ -1,4 +1,5 @@
 import { FidesCookie } from "./cookie";
+import { debugLog } from "./consent-utils";
 
 /**
  * Defines the available event names:
@@ -40,13 +41,20 @@ export type FidesEvent = CustomEvent<FidesEventDetail>;
  */
 export const dispatchFidesEvent = (
   type: FidesEventType,
-  cookie: FidesCookie
+  cookie: FidesCookie,
+  debug: boolean
 ) => {
   if (typeof window !== "undefined" && typeof CustomEvent !== "undefined") {
     // Pick a subset of the Fides cookie properties to provide as event detail
     const { consent }: FidesEventDetail = cookie;
     const detail: FidesEventDetail = { consent };
     const event = new CustomEvent(type, { detail });
+    debugLog(
+      debug,
+      `Dispatching event type ${type} with cookie consent ${JSON.stringify(
+        cookie?.consent
+      )}`
+    );
     window.dispatchEvent(event);
   }
 };

clients/fides-js/src/lib/preferences.ts

@@ -90,5 +90,5 @@ export const updateConsentPreferences = ({
     });
 
   // 5. Dispatch a "FidesUpdated" event
-  dispatchFidesEvent("FidesUpdated", cookie);
+  dispatchFidesEvent("FidesUpdated", cookie, debug);
 };

clients/privacy-center/cypress/e2e/consent-banner.cy.ts

@@ -190,7 +190,7 @@ describe("Consent banner", () => {
   });
 
   describe("when user has no saved consent cookie", () => {
-    describe("when banner is not disabled", () => {
+    describe("when overlay is enabled", () => {
       beforeEach(() => {
         cy.getCookie(CONSENT_COOKIE_NAME).should("not.exist");
         stubConfig({