Skip to content

Commit

Permalink
Remove disabled Nav Buttons (#1067)
Browse files Browse the repository at this point in the history
* Update NavBar.tsx

* remove "more" from the navbar

* fix a linting error

* remove cypress tests for disabled links
  • Loading branch information
ThomasLaPiana authored Sep 12, 2022
1 parent 3abc3c4 commit 048b949
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
5 changes: 0 additions & 5 deletions clients/ctl/admin-ui/cypress/e2e/nav-bar.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ describe("Nav Bar", () => {
cy.getByTestId("nav-link-Taxonomy");
cy.getByTestId("nav-link-Systems");

// Disabled links

cy.getByTestId("nav-link-Policies").should("have.attr", "disabled");
cy.getByTestId("nav-link-User Management").should("have.attr", "disabled");
cy.getByTestId("nav-link-More").should("have.attr", "disabled");
});

it("Renders the active page based on the current route", () => {
Expand Down
9 changes: 0 additions & 9 deletions clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import dynamic from "next/dynamic";
import React from "react";

import { useFeatures } from "~/features/common/features.slice";
import { ArrowDownLineIcon } from "~/features/common/Icon";

// Cross-zone navigation requires building URLs from the current `window.location`
// which is not available in Server-Side-Rendered components.
Expand All @@ -27,17 +26,9 @@ const NavBar = () => {
{/* Links under the datamap zone: */}
{features.plus ? <NavLink title="Data Map" href="/datamap" /> : null}

<NavLink title="Policies" href="/policy" disabled />
<NavLink title="Taxonomy" href="/taxonomy" />
<NavLink title="User Management" href="/user-management" disabled />
{/* This is a temporary link to the config wizard while it's still in progress */}
<NavLink title="Config Wizard" href="/config-wizard" />
<NavLink
title="More"
href="#"
rightIcon={<ArrowDownLineIcon />}
disabled
/>
</nav>
</Flex>
);
Expand Down

0 comments on commit 048b949

Please sign in to comment.