Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix re-entrance #108

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Fix re-entrance #108

merged 9 commits into from
Sep 23, 2024

Conversation

syntrust
Copy link
Contributor

@syntrust syntrust commented Sep 5, 2024

Issue to address:

Solution:

Tests:

  • First mocked a re-entrance attack to drain funds from the storage contract.
  • Then verify that the noReentrant modifier will revert the same test.

@syntrust syntrust requested review from qzhodl and iteyelmp September 5, 2024 03:10
@syntrust syntrust marked this pull request as draft September 5, 2024 03:51
@syntrust syntrust marked this pull request as ready for review September 9, 2024 08:52
@syntrust syntrust requested a review from qzhodl September 12, 2024 02:44
@qzhodl qzhodl requested a review from ping-ke September 13, 2024 08:53
@syntrust syntrust requested a review from qizhou September 19, 2024 10:56
@syntrust syntrust merged commit d118b11 into main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants