Fix "diff not match" #106
Closed
Fix "diff not match" #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Aug 27, 2024
| @@ -33,12 +33,12 @@ library MiningLib { | |||
| uint256 interval = _mineTime - _info.lastMineTime; | |||
| uint256 diff = _info.difficulty; | |||
| if (interval < _cutoff) { | |||
| diff = diff + ((1 - interval / _cutoff) * diff) / _diffAdjDivisor; | |||
| diff = diff + (diff - interval * diff / _cutoff) / _diffAdjDivisor; | |||
There was a problem hiding this comment.
As we discussed in the sync meeting, we may not want to change the alg in the smart contact.
|
It should be an es-node issue according to the discussion in ethstorage/pm#116 See ethstorage/es-node#315 instead. Origin: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing ethstorage/es-node#304.
The current expectedDiff() in MiningLib.sol appears to have lost accuracy compared to the implementation in es-node, leading to rare cases where the computed difficulty does not match.
The fix aligns with the algorithm described here: https://github.com/ethstorage/es-node/blob/87a1fe723871dc319e2e7761cacc38c5aaf92ee8/ethstorage/miner/algorithm.go#L43
The unit test utilizes actual input data from a previously failed case.