Opening a new shard fix #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Aug 27, 2024
|
Was there a testing scenario that led you to discover this issue? If so, it would be helpful to describe the bug in the PR description. |
qzhodl
approved these changes
Aug 29, 2024
iteyelmp
approved these changes
Sep 3, 2024
Abstract block info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the shardId computation when uploading blobs in batch.
Also for accurate upfront payment.
Discover:
putBlobsreverts when a new shard is opening when doing the tests:Run the following cmd with code ethstorage/es-node#187
which covers calling
putBlobswith msg.value got fromupfrontPaymentInBatch(uint256 _batchSize)