Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for partial sgt #83

Merged
merged 1 commit into from
Nov 4, 2024
Merged

add test for partial sgt #83

merged 1 commit into from
Nov 4, 2024

Conversation

blockchaindevsh
Copy link

This PR adds 3 testcases for SGT:

  1. tx.value > acc.balance & tx.cost < acc.balance + acc.sgt_balance, should fail
  2. tx.cost > acc.balance + acc.sgt_balance, should fail
  3. tx.value <= acc.balance && tx.cost <= acc.balance + acc.sgt_balance, should succeed

@blockchaindevsh blockchaindevsh merged commit 409ef8b into op-es Nov 4, 2024
@blockchaindevsh blockchaindevsh deleted the test_partial_sgt branch November 4, 2024 12:09
@blockchaindevsh blockchaindevsh mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajuguan dajuguan dajuguan approved these changes

@qizhou qizhou qizhou approved these changes

@qzhodl qzhodl Awaiting requested review from qzhodl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blockchaindevsh @qizhou @dajuguan