fix bug: connection with DirInbound may not have addresses in Peerstore.

ethstorage/p2p/node.go

@@ -96,25 +96,27 @@ func (n *NodeP2P) init(resourcesCtx context.Context, rollupCfg *rollup.EsConfig,
 					shards       map[common.Address][]uint64
 					remotePeerId = conn.RemotePeer()
 				)
-				if len(n.host.Peerstore().Addrs(remotePeerId)) == 0 {
-					// As the node host enable NATService, which will create a new connection with another
-					// peer id and its Addrs will not be set to Peerstore, so if len of peer Addrs is 0,
-					// then ignore this connection.
-					log.Debug("No addresses to get shard list, return without close conn", "peer", remotePeerId)
-					return
-				}
 				css, err := n.Host().Peerstore().Get(remotePeerId, protocol.EthStorageENRKey)
 				if err != nil {
 					// for node which is new to the ethstorage network, and it dial the nodes which do not contain
 					// the new node's enr, so the nodes do not know its shard list from enr, so it needs to call
 					// n.RequestShardList to fetch the shard list of the new node.
 					remoteShardList, e := n.RequestShardList(remotePeerId)
-					if e != nil {
-						log.Debug("Get remote shard list fail", "peer", remotePeerId, "err", e.Error())
+					if e != nil && len(n.host.Peerstore().Addrs(remotePeerId)) == 0 {
+						// As the node host enable NATService, which will create a new connection with another
+						// peer id and its Addrs will not be set to Peerstore. So if len of peer Addrs is 0 and
+						// cannot get the remote node's shard list, then ignore this connection.
+						log.Debug("No addresses to get shard list, return without close conn", "peer", n.host.ID(), "remote peer",
+							remotePeerId, "Direction", conn.Stat().Direction, "remote address", conn.RemoteMultiaddr().String(), "error", e.Error())
+						return
+					} else if e != nil {
+						log.Debug("Get remote shard list fail", "peer", remotePeerId, "Direction", conn.Stat().Direction,
+							"remote address", conn.RemoteMultiaddr().String(), "err", e.Error())
 						conn.Close()
 						return
 					}
-					log.Debug("Get remote shard list success", "peer", remotePeerId, "shards", remoteShardList)
+					log.Debug("Get remote shard list success", "peer", remotePeerId, "shards", remoteShardList,
+						"Direction", conn.Stat().Direction, "remote address", conn.RemoteMultiaddr().String())
 					n.Host().Peerstore().Put(remotePeerId, protocol.EthStorageENRKey, remoteShardList)
 					shards = protocol.ConvertToShardList(remoteShardList)
 				} else {

ethstorage/p2p/notifications.go

@@ -46,11 +46,11 @@ func (notif *notifications) ListenClose(n network.Network, a ma.Multiaddr) {
 }
 func (notif *notifications) Connected(n network.Network, v network.Conn) {
 	notif.m.IncPeerCount()
-	notif.log.Info("Connected to peer", "peer", v.RemotePeer(), "addr", v.RemoteMultiaddr())
+	notif.log.Info("Connected to peer", "peer", v.RemotePeer(), "Direction", v.Stat().Direction, "addr", v.RemoteMultiaddr())
 }
 func (notif *notifications) Disconnected(n network.Network, v network.Conn) {
 	notif.m.DecPeerCount()
-	notif.log.Info("Disconnected from peer", "peer", v.RemotePeer(), "addr", v.RemoteMultiaddr())
+	notif.log.Info("Disconnected from peer", "peer", v.RemotePeer(), "Direction", v.Stat().Direction, "addr", v.RemoteMultiaddr())
 }
 func (notif *notifications) OpenedStream(n network.Network, v network.Stream) {
 	notif.m.IncStreamCount()