Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go-rapidsnark in addition to snarkjs with a flag (Part 2) #281

Merged
merged 44 commits into from
Jul 2, 2024

Conversation

syntrust
Copy link
Collaborator

@syntrust syntrust commented Apr 29, 2024

The main issue this PR resolves is failure to compile on the github workflow for macos platform with go-rapidsnark introduced:

build constraints exclude all Go files in /home/runner/go/pkg/mod/github.com/iden3/go-rapidsnark/[email protected]
  1. To avoid cross-platform with cgo, change github workflow build strategy to build on separate platforms
  2. Enable cgo in Makefile to build with go-rapidsnark
  3. Fix prover using the wrong wasm file with snarkjs
  4. update tests
  5. update run.sh to handle different implementations.

Also check ethstorage/ethstorage-doc#26 for docs change.

Known issue: go-rapidsnark crashes with go1.22.2 darwin/amd64, see iden3/go-rapidsnark#18.

Update: the above issue is resolved after go-rapidsnark prover upgraded to v0.0.11, verified on go1.22.3 darwin/amd64.

@syntrust syntrust force-pushed the rapidsnark-test branch from 722b0d8 to bea15c4 Compare May 9, 2024 08:01
@qzhodl qzhodl self-requested a review May 31, 2024 10:40
@qzhodl
Copy link
Collaborator

qzhodl commented May 31, 2024

It seems that the crashing issue is a blocker for us to merge the PR. Additionally, go-rapidsnark is not updated very frequently, while rapidsnark is updated more quickly.

@qzhodl
Copy link
Collaborator

qzhodl commented Jul 2, 2024

One small concern is that I am not sure if it can compile successfully on Windows after we support go-rapidsnark

@syntrust
Copy link
Collaborator Author

syntrust commented Jul 2, 2024

One small concern is that I am not sure if it can compile successfully on Windows after we support go-rapidsnark

Test shows at least we can compile successfully on macos with CGO_ENABLED=0 GOOS=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants