-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support go-rapidsnark in addition to snarkjs with a flag (Part 2) #281
Conversation
…to rapidsnark-test
…to rapidsnark-test
…to rapidsnark-test
…to rapidsnark-test
It seems that the crashing issue is a blocker for us to merge the PR. Additionally, go-rapidsnark is not updated very frequently, while rapidsnark is updated more quickly. |
…to rapidsnark-test
…to rapidsnark-test
…to rapidsnark-test
…to rapidsnark-test
One small concern is that I am not sure if it can compile successfully on Windows after we support go-rapidsnark |
Test shows at least we can compile successfully on macos with |
The main issue this PR resolves is failure to compile on the github workflow for macos platform with
go-rapidsnark
introduced:Also check ethstorage/ethstorage-doc#26 for docs change.
Known issue: go-rapidsnark crashes with go1.22.2 darwin/amd64, see iden3/go-rapidsnark#18.Update: the above issue is resolved after go-rapidsnark prover upgraded to v0.0.11, verified on go1.22.3 darwin/amd64.