Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimization: generate zk proof for 2 samples at once #167

Merged
merged 31 commits into from
Jan 10, 2024
Merged

optimization: generate zk proof for 2 samples at once #167

merged 31 commits into from
Jan 10, 2024

Conversation

syntrust
Copy link
Collaborator

@syntrust syntrust commented Dec 25, 2023 •
edited
Loading

Addressing issue #179

  1. Apply contract change for new circuit (Support new circuit storage-contracts-v1#47) to es-node
  2. integration tests updates
  3. Add flag "miner.zk-prover-version" to support both versions of the circuit

@syntrust syntrust changed the title (Draft) optimization: build a circuit to verify multiple sampling on multiple blobs (Draft) optimization: generate zk proof for 2 samples at once Dec 26, 2023
@syntrust syntrust mentioned this pull request Dec 26, 2023
Closed
@syntrust syntrust requested a review from qzhodl December 28, 2023 04:01
@syntrust syntrust mentioned this pull request Jan 2, 2024
Closed
@syntrust syntrust changed the title (Draft) optimization: generate zk proof for 2 samples at once optimization: generate zk proof for 2 samples at once Jan 5, 2024
qzhodl
qzhodl reviewed Jan 8, 2024
View reviewed changes
ethstorage/miner/cli.go Outdated Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
run.sh Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
ethstorage/prover/zk_prover.go Show resolved Hide resolved
integration_tests/kzg_prover_test.go Outdated Show resolved Hide resolved
@qzhodl qzhodl mentioned this pull request Jan 8, 2024
Closed
@syntrust syntrust requested a review from qzhodl January 9, 2024 04:06
qzhodl
qzhodl reviewed Jan 9, 2024
View reviewed changes
ethstorage/prover/kzg_poseidon_prover.go Outdated Show resolved Hide resolved
integration_tests/zk_prover_test.go Outdated Show resolved Hide resolved
@syntrust syntrust requested a review from qzhodl January 10, 2024 04:28
@syntrust syntrust merged commit 1be56ae into main Jan 10, 2024
2 checks passed
@syntrust syntrust mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qzhodl qzhodl qzhodl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syntrust @qzhodl