-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to web3 v5 #137
Update to web3 v5 #137
Conversation
3d4fc55
to
993b75b
Compare
Would be pretty cool to get the
|
setup.py
Outdated
'py-solc>=3.2.0,<4', | ||
'rlp>=1.0.1,<2', | ||
'web3[tester]>=4.7,<5', | ||
'web3[tester]>=5.0.0a2,<6.0.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a testing dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pipermerriam The [tester]
splinter is a testing dependency, but web3
by itself is needed for a user to use py-ethpm
.
I tried moving web3[tester]>=5.0.0a3,<6.0.0
to the test
section of extras_require
and leaving web3>=5.0.0a3,<6.0.0
in the install_requires
section, in the hopes that the [tester]
splinter would only be installed with [test]
or [dev]
. But this failed to install eth_tester
when running pip install -e .[dev]
.
Is there a better way to handle only installing the [tester]
splinter in a the extras_require[test]
env, but the same web3
version without the [tester]
splinter in install_requires
?
1a629f9
to
90e3858
Compare
90e3858
to
3910365
Compare
@mikeshultz Noted - created issue #140 to track, but moving ahead to merge this |
What was wrong?
update to web3 v5 and remove eth-abi dependency
Cute Animal Picture
🦔