Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to web3 v5 #137

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Conversation

njgheorghita
Copy link
Contributor

What was wrong?

update to web3 v5 and remove eth-abi dependency

Cute Animal Picture

🦔

@njgheorghita njgheorghita force-pushed the update-to-web3-v5 branch 5 times, most recently from 3d4fc55 to 993b75b Compare December 21, 2018 14:55
@mikeshultz
Copy link

Would be pretty cool to get the web3[tester] splinter pulled out, or optional somehow. The web3[tester] splinter/extras don't look like they're required to run py-ethpm as a user. Not sure if this is the best way to go about it, but maybe something like this?

from setuptools.command.develop import develop as _develop
from subprocess import check_call

[...]

class develop(_develop):
    """ Post-installation to make sure web3 tester extras are installed."""
    def run(self):
        _develop.run(self)
        check_call(['pip', 'install', 'web3[tester]>=5.0.0a2,<6.0.0'])

setup(
    [...]
    install_requires=[
        [...]
        'web3>=5.0.0a2,<6.0.0',
    ],
    [...]
    cmdclass={
        'develop': develop,
    },
)

setup.py Outdated
'py-solc>=3.2.0,<4',
'rlp>=1.0.1,<2',
'web3[tester]>=4.7,<5',
'web3[tester]>=5.0.0a2,<6.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a testing dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pipermerriam The [tester] splinter is a testing dependency, but web3 by itself is needed for a user to use py-ethpm.

I tried moving web3[tester]>=5.0.0a3,<6.0.0 to the test section of extras_require and leaving web3>=5.0.0a3,<6.0.0 in the install_requires section, in the hopes that the [tester] splinter would only be installed with [test] or [dev]. But this failed to install eth_tester when running pip install -e .[dev].

Is there a better way to handle only installing the [tester] splinter in a the extras_require[test] env, but the same web3 version without the [tester] splinter in install_requires?

@njgheorghita njgheorghita force-pushed the update-to-web3-v5 branch 3 times, most recently from 1a629f9 to 90e3858 Compare January 16, 2019 14:34
@njgheorghita
Copy link
Contributor Author

@mikeshultz Noted - created issue #140 to track, but moving ahead to merge this

@njgheorghita njgheorghita merged commit 9ace7f9 into ethpm:master Jan 16, 2019
@njgheorghita njgheorghita deleted the update-to-web3-v5 branch January 16, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants