-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: request result simulation #236
Draft
pk910
wants to merge
49
commits into
master
Choose a base branch
from
pk910/request-simulation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferenced from the activity cache (huge memory leak for big networks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simulator for el triggered requests, that allows showing more details about the request outcome:
![image](https://private-user-images.githubusercontent.com/491045/411277515-cfe5e149-6ae3-47ad-9f96-e9dcfef2cc19.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTgzMzAsIm5iZiI6MTczOTM5ODAzMCwicGF0aCI6Ii80OTEwNDUvNDExMjc3NTE1LWNmZTVlMTQ5LTZhZTMtNDdhZC05Zjk2LWU5ZGNmZWYyY2MxOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjA3MTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMTc1OWRlZDUwODg2ODJiMzQ2YzRiMDBjMTQzM2UyZGUyMDNjZTVkMDFkNDhkZmVlMmE5YzA5MTNiNDg4N2FiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0VsNBcWUL7Nagv4gVqNeudGc6Joklbk2m5uRx1-HS78)
Simulation is needed because dora does not fetch and hold a full beacon state for each epoch. Beacon states are only available for the dependent block of each epoch - which is normally the post-state of the last slot in previous epoch.
To make accurate assumptions about the outcome of el triggered requests at any slot number, dora needs to replay all blocks on top of the last available state, simulating all relevant operations that have an effect of the validator set (partial withdrawals, voluntary exits, slashings, consolidations & withdrawal requests).
Fortunately, all blocks are available in memory and the max number of blocks to process is limited by the number of slots in one epoch, so the CPU overhead for this simulation should be manageable. However, to avoid potential computation bottlenecks, the simulation results are also cached in the block container.
Simulation results for consolidation requests
Simulation results for withdrawal requests
Test instance running for pectra-devnet-6:
http://157.180.18.78:8080/validators/el_consolidations?f=&f.minsi=100&f.orphaned=1&c=50
gated on: