Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add react-webpack example #36

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

feat: add react-webpack example #36

wants to merge 24 commits into from

Conversation

amochuko
Copy link

An example project using React and Webpack for #31

@Cafe137
Copy link
Collaborator

Cafe137 commented Sep 10, 2024

Hello!

There seems to be an issue on how localStorage is handled. When I start from zero, it does not prompt me for a Bee URL, and the App does not mount at all.

Can you please try clearing your localStorage and see if you can reproduce the issue I am having?

Thank you.

@amochuko
Copy link
Author

Hello!

There seems to be an issue on how localStorage is handled. When I start from zero, it does not prompt me for a Bee URL, and the App does not mount at all.

Can you please try clearing your localStorage and see if you can reproduce the issue I am having?

Thank you.

Thank you for your response. Give me some minutes to reproduce that.

@amochuko
Copy link
Author

Hello!
There seems to be an issue on how localStorage is handled. When I start from zero, it does not prompt me for a Bee URL, and the App does not mount at all.
Can you please try clearing your localStorage and see if you can reproduce the issue I am having?
Thank you.

Thank you for your response. Give me some minutes to reproduce that.

I was able to reproduce the issue as you've stated. Am working on a fix and will get back to you once done.
Thanks

@amochuko
Copy link
Author

I have made the update regarding the localStorage issue. It should run this time.

Cafe137
Cafe137 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@Cafe137 Cafe137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@amochuko
Copy link
Author

LGTM, thank you!

Thank you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cafe137 Cafe137 Cafe137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amochuko @Cafe137