-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go-ethereum #2342
Conversation
984c844
to
ac44bfe
Compare
18b69b7
to
7e41f2e
Compare
36fc80a
to
1a5387f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 12 files at r1, 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @acud)
pkg/transaction/backendsimulation/backend.go, line 163 at r2 (raw file):
} func (m *simulatedBackend) SuggestGasTipCap(ctx context.Context) (*big.Int, error) {
Since the ctx
isn't used I'd suggest changing the name to _
in order to explicitly signal that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 12 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ralph-pichler)
go.sum, line 794 at r2 (raw file):
github.com/mattn/go-runewidth v0.0.9 h1:Lm995f3rfxdpd6TSmuVCHVb/QhupuXlYr8sCI/QdE+0= github.com/mattn/go-runewidth v0.0.9/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m2gUSrubnMI= github.com/mattn/go-sqlite3 v1.11.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsOqkbpncsNc=
?? i wonder where is this coming from? did you go mod tidy
?
pkg/statestore/leveldb/migration.go, line 138 at r2 (raw file):
if err = s.Put(fixed, chequebookAddress); err != nil { return err }
what about s.Delete(key)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acud)
go.sum, line 794 at r2 (raw file):
Previously, acud (acud) wrote…
?? i wonder where is this coming from? did you
go mod tidy
?
yes. both go-ethereum and go-ens have this in their go.sum also, so probably one of their dependencies introduced this.
pkg/statestore/leveldb/migration.go, line 138 at r2 (raw file):
Previously, acud (acud) wrote…
what about
s.Delete(key)
?
added
pkg/transaction/backendsimulation/backend.go, line 163 at r2 (raw file):
Previously, mrekucci wrote…
Since the
ctx
isn't used I'd suggest changing the name to_
in order to explicitly signal that.
deleted as it was no longer needed after downgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 12 files at r1, 4 of 4 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ralph-pichler)
v1.10.3
(last version which works with clef for non-london txs, see cannot sign non-eip 1559 with clef using external.ExternalSigner ethereum/go-ethereum#23273)This change is