Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle getBlockNumber errors on polling #1235

Closed
wants to merge 1 commit into from
Closed

Handle getBlockNumber errors on polling #1235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions packages/providers/src.ts/base-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,16 +598,8 @@ export class BaseProvider extends Provider implements EnsProvider {

const checkInternalBlockNumber = resolveProperties({
blockNumber: this.perform("getBlockNumber", { }),
networkError: this.getNetwork().then((network) => (null), (error) => (error))
}).then(({ blockNumber, networkError }) => {
if (networkError) {
// Unremember this bad internal block number
if (this._internalBlockNumber === checkInternalBlockNumber) {
this._internalBlockNumber = null;
}
throw networkError;
}

networkError: this.getNetwork(),
}).then(({ blockNumber }) => {
const respTime = getTime();

blockNumber = BigNumber.from(blockNumber).toNumber();
Expand All @@ -616,6 +608,12 @@ export class BaseProvider extends Provider implements EnsProvider {
this._maxInternalBlockNumber = blockNumber;
this._setFastBlockNumber(blockNumber); // @TODO: Still need this?
return { blockNumber, reqTime, respTime };
}).catch((error) => {
// Unremember this bad internal block number
if (this._internalBlockNumber === checkInternalBlockNumber) {
this._internalBlockNumber = null;
}
throw error;
});

this._internalBlockNumber = checkInternalBlockNumber;
Expand Down