Gas estimation error is not forwarded to the caller in v5-beta

[sz-piotr]

Relevant code:
https://github.com/ethers-io/ethers.js/blob/ethers-v5-beta/packages/abstract-signer/src.ts/index.ts#L170-L176

In Waffle (https://github.com/EthWorks/waffle) we rely on ganache throwing an error containing the revert message during gas estimation in order for matchers like .revertedWith(message) to work. The new ethers behaviour eliminates this possibility.

Is there anything that we can do to be able to see error message similar to those that were in v4?

RuntimeError: VM Exception while processing transaction: revert Reason

[ricmoo]

I'd generally prefer systems like Ganache find a more standards compliant way to bubble errors like this back to the user (and in this case, should not trigger an error at all), but since it is a service fairly widely adopted already, does it help if the wrapped error includes the original error?

It would be accessible at error.error to get the original error...

Sound fair/good? :)

[ricmoo]

(actually; I may be wrong. I'm not sure what a standard node would do in this case, I should research that a bit. And bring it up in my talks with the Eth2 peeps on standardizing errors.)

[ricmoo]

The error should now be available in 5.0.0-beta.187. Try it out and let me know if that works for you. :)

[sz-piotr]

I will get back to you as soon as we try it out in waffle

[ricmoo]

Awesome. I'll close this for now then, because I think that should address your issue. But if it is still a problem, or inadequate, please re-open.

Thanks! :)