ReferenceError in JsonRpcProvider

[wighawag]

Getting this error

 Uncaught (in promise) ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor

in

ethers.js/packages/providers/src.ts/json-rpc-provider.ts

Line 238 in 7f0374c

super(this.detectNetwork());

[ricmoo]

Did you remove your node_modules and lock files? I’ll look into this right away.

[ricmoo]

Actually... Weird, why am I not getting that compile time issue??

[ricmoo]

This is definitely a bug. And I'm concerned my TypeScript compiler isn't detecting it. What version are you using?

If I reorder the operations a bit, I can get my compiler to (correctly) complain.

[ricmoo]

I've got a fix in place, just testing now.

I've simplified the types JsonRpcProvider can accept as well. Previously you could do something like new JsonRpcProvider("homestead"), leaving the url empty and it would realize and use the default localhost url on homestead. Now you will need to pass null in as a first parameter to use the default.

This is not as important now, since the eth_chainId method is wide-spread. Historically there network detection was unreliable, but I would argue is actually the preferred method these days. ;)

[ricmoo]

The CI has finally passed and this has been published to 5.0.0-beta.186. I've also bumped all the package.json versions in each package.json, so there should be no need to clear out node_modules, etc.

Try it out and let me know if there is still a problem.

I'm also still interested in reproducing the original issue locally. Can you pass along what version of TypeScript you were using? My version let that through without issue. Maybe there is a tsconfig setting (which would seem weird to allow wildly unsafe behaviour).

Thanks!

[wighawag]

The issue was in the umd output of this lib : https://github.com/wighawag/svelte-wallet that use rollup to bundle the output in multiple format.

the umd output was then used in my application and got the error mentioned at runtime

[ricmoo]

Does the latest issue still have this problem?

I will also be opening a bug with TypeScript later (I've searched a bit but haven't found an already existing issue on their repo). I'll link to it here.

[wighawag]

The issue happening at this line here : https://github.com/wighawag/svelte-wallet/blob/1614d0d47b1ee8da16e0fc642fbe027f8f27b30c/dist/svelte-wallet.umd.js#L17356

[wighawag]

The latest seem to works fine

[ricmoo]

Awesome. Yeah, that line was in the older version. Glad it works now. :)

[wighawag]

But maybe this will fail too : https://github.com/wighawag/svelte-wallet/blob/929b852a8fe282baf82f38dfea17c2d5751833ec/dist/svelte-wallet.umd.js#L18426

[ricmoo]

Ah yes... I think that will.

Thanks, I'll grep the source for all uses of super.

[ricmoo]

I've opened this bug on TypeScript. Let me know if there is anything else to add.

[ricmoo]

FYI. Looks like that issue has been marked to be fixed in TypeScript 4. :)

[ricmoo]

The FallbackProvider has also been updated and is available in 5.0.0-beta.187.

[ricmoo]

Closing this now, but if you have any more issues please re-open.

Thanks! :)