-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow gasLimit
to be specified on eth_call
s
#819
Labels
enhancement
New feature or improvement.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
Comments
I was under the impression that call ignored the gasLimit, but I'll experiment and can add it as a valid call override. |
Something like this might be useful for checking: contract EthCallGasDependent {
function txGasEnough() external pure returns (bool) { return gasleft() > 20000; }
} |
This should have happened as a consequence of the Contract refactor in 5.0.0-beta.189. Try it out and let me know if there are still issues. |
ricmoo
added
the
fixed/complete
This Bug is fixed or Enhancement is complete and published.
label
May 30, 2020
This should be fixed now. If not, please re-open. Thanks! :) |
michaeltout
pushed a commit
to michaeltout/ethers.js
that referenced
this issue
Aug 23, 2020
michaeltout
pushed a commit
to michaeltout/ethers.js
that referenced
this issue
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or improvement.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
Related: #316
If trying to specify
gasLimit
on aneth_call
, ethers.js will throw anError: call cannot override gasLimit
. Sometimes, being able to override the gas limit is desirable though, like when trying to determine how a different gas limit might affect the result of a call.For example,
eth_call
ingexecTransaction
on a Gnosis Safe with different gas limits to see where the transaction success value changes.Also related: #299
Nodes will expect to see a
gas
parameter, and whileeth_sendTransaction
can be handled by signing transactions on the frontend, foreth_call
to work, one would either have to allow/preserve thegas
name expected by nodes or transformgasLimit
togas
on the backend.The text was updated successfully, but these errors were encountered: