ContractFactory.interface.deployFunction: _DeployDescription defaults to payable: true

[gitpusha]

Hi. This is a very minor seemingly non-critical thing I observed:

For solidity contracts that do not have any constructors the ContractFactory object returned by new ethers.ContractFactory() seems to have payable: true set by default in its ContractFactory.interface.deployFunction property.

This seems odd. Should it not be a payable: false default if NO constructor is present in the solidity source?

Not critical because contract deploys anyway, even though it does not have a payable constructor, nor is value required to be sent with the deployment tx.

[ricmoo]

This, unfortunately, is the case because early Solidity did not have the payable keyword; by default all functions and constructors were payable.

But it is a good point, I should update v5 to default to assume modern Solidity semantics and force anyone updating to v5 from v4 to update their ABI to include payable if they are importing a very old ABI.

[gitpusha]

thanks for all the great work! I love ethers.js and I am currently using it with buidler.

[ricmoo]

This was added a while ago, I just forgot to update the ticket. If you are still having issues, please feel free to re-open.

Thanks! :)