"checkError" incorrectly for used nonce.

[ricmoo]

Discussed in #2845

^{Originally posted by timaiv March 26, 2022}
ethers.js check "nonce too low".
Currently alchemy and infura nodes return "nonce is too low".

[ricmoo]

I’ll look into this in the morning.

[ricmoo]

I've tested this on Ropsten, and the string I get is still "nonce too low", there is no "is". Is this something that is on only mainnet? I'd rather confirm this is the case before spending real ether to validate.

[timaiv]

I've tested this on Ropsten, and the string I get is still "nonce too low", there is no "is". Is this something that is on only mainnet? I'd rather confirm this is the case before spending real ether to validate.

I have tested on kovan.
OE nodes return "nonce is too low".
https://github.com/openethereum/openethereum/blob/main/crates/rpc/src/v1/helpers/errors.rs#L376

Geth nodes return "nonce too low".
https://github.com/ethereum/go-ethereum/blob/master/core/error.go#L48

[ricmoo]

I was able to reproduce on Kovan and will get a fix out today.

Thanks! :)

[ricmoo]

This has been fixed in 5.6.4. Please try it out and let me know if you have any issues.

Thanks! :)

[timaiv]

This has been fixed in 5.6.4. Please try it out and let me know if you have any issues.

Thanks! :)

Please, update also REPLACEMENT_UNDERPRICED for OE, in my libs:

if (message.match(/replacement transaction underpriced|Transaction gas price (supplied|\d+wei) is too low/)) {

https://github.com/openethereum/openethereum/blob/6c2d392d867b058ff867c4373e40850ca3f96969/crates/rpc/src/v1/helpers/errors.rs#L377

ethers.js supports only GETH version
https://github.com/ethereum/go-ethereum/blob/master/core/tx_pool.go#L74

[ricmoo]

I've added the change for REPLACEMENT_TRANSACITON too.

Thanks! :)