Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null on call exceptions for EnsResolver methods #1690

Closed
ricmoo opened this issue Jun 19, 2021 · 3 comments
Closed

Return null on call exceptions for EnsResolver methods #1690

ricmoo opened this issue Jun 19, 2021 · 3 comments
Assignees
@ricmoo
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Jun 19, 2021

When using the methods on an EnsResolver (via provider.getResolver()) any CALL_EXCEPTION can be trapped as effectively not configured and null should be returned.
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. labels Jun 19, 2021
@ricmoo ricmoo self-assigned this Jun 19, 2021
ricmoo added a commit that referenced this issue Jun 24, 2021
@ricmoo
Trap CALL_EXCEPTION errors when resolving ENS entries (#1690).
91951dc
@ricmoo
Copy link
Member Author

ricmoo commented Jun 26, 2021

This has been fixed in 5.4.0. Try it out and let me know how if you still have any issues. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 26, 2021
@ricmoo ricmoo closed this as completed Jul 2, 2021
@snyk-bot snyk-bot mentioned this issue Sep 6, 2021
Open
@timaiv
Copy link

timaiv commented Nov 22, 2021 •
edited
Loading

@ricmoo
Fallback provider.
After your fix, provider https://data-seed-prebsc-2-s1.binance.org:8545/ that currently returns 404 / 503 error, (and actually error.status 404, or 503 Service Unavailable)
error on eth_call is forwarded (because changed from SERVER_ERROR to CALL_EXCEPTION), i think we need check http status.

@zemse
Copy link
Collaborator

zemse commented Nov 24, 2021

After your fix, provider https://data-seed-prebsc-2-s1.binance.org:8545/ that currently returns 404 / 503 error, (and actually error.status 404, or 503 Service Unavailable)

Hey @timaiv, are you sure that the node is up and running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ricmoo @zemse @timaiv