BigNumber.toString breaking change not in V5 migration guide

[matYang]

This references Why doesn't BigNumber.toString allow an arbitrary base? #889

I'm getting the same error after upgrading to Ethers V5 from V4 because I had places that call .toString(10) on results from Ethers. Read through the #889 thread, I guess it makes sense, but be aware it could confuse people, as toString(10) is the go-to function in the actual BigNumber library to print a really big number without exponential notation.

Anyways, it is a breaking change, but it is not mentioned here https://docs.ethers.io/v5/migration/ethers-v4/#migration-v4--bignumber

[ricmoo]

The base was always ignored, and it is somewhat dangerous to include it (since another developer may believe it follows the BN.js convention), but you are correct it did not throw.

I will add a note to the migration docs. :)

[ricmoo]

I actually think, since I already do the check in toString, I will allow the value 10 passed in; however it will emit a warning the first time it is used...

Thoughts?

[ricmoo]

(also, for people who stumble across this in the future, previous relevant issues are: #248, #889)

[ricmoo]

This has been addressed in 5.0.22. It will now log a warning the first time value.toString(10) is called and throw a more useful error on any other value passed in.

Try it out and let me know how it works for you.

Thanks! :)

[ricmoo]

Closing this now. If you have any further issues, please re-open. :)