Fixed splitSignature when recoveryParam is encoded directly (#893, #933…

…).
ethers-io · Jul 8, 2020 · bf65ddb · bf65ddb
1 parent 7e56f3d
commit bf65ddb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/bytes/src.ts/index.ts b/packages/bytes/src.ts/index.ts
@@ -340,9 +340,6 @@ export function splitSignature(signature: SignatureLike): Signature {
         result.s = hexlify(bytes.slice(32, 64));
         result.v = bytes[64];
 
-        // Compute recoveryParam from v
-        result.recoveryParam = 1 - (result.v % 2);
-
         // Allow a recid to be used as the v
         if (result.v < 27) {
             if (result.v === 0 || result.v === 1) {
@@ -352,6 +349,9 @@ export function splitSignature(signature: SignatureLike): Signature {
             }
         }
 
+        // Compute recoveryParam from v
+        result.recoveryParam = 1 - (result.v % 2);
+
         // Compute _vs from recoveryParam and s
         if (result.recoveryParam) { bytes[32] |= 0x80; }
         result._vs = hexlify(bytes.slice(32, 64))