Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Update dependencies #78

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Update dependencies #78

merged 3 commits into from
Dec 19, 2018

Conversation

axic
Copy link
Member

@axic axic commented Dec 19, 2018 •
edited
Loading

Fixes #47. Fixes #75.

@axic axic requested a review from holgerd77 December 19, 2018 00:11
axic
axic commented Dec 19, 2018
View reviewed changes
package.json
"randombytes": "^2.0.6",
"safe-buffer": "^5.1.2",
"scrypt.js": "^0.2.0",
"scrypt.js": "^0.3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main benefit is upgrading this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.199% when pulling 2a5f319 on update-deps into 2d1c13b on master.

holgerd77
holgerd77 approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, checked all occurrences of ethUtil calls, no functionality with changed behavior from v5.2.0 to v6.0.0 is used within the library.

@holgerd77 holgerd77 merged commit 088b0a9 into master Dec 19, 2018
@holgerd77 holgerd77 deleted the update-deps branch December 19, 2018 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @coveralls @holgerd77