Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Remove dependency on crypto #63

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Remove dependency on crypto #63

merged 1 commit into from
Sep 24, 2018

Conversation

axic
Copy link
Member

@axic axic commented Jul 28, 2018

Closes #18.

Fixes #8.

@coveralls
Copy link

coveralls commented Jul 28, 2018

Coverage Status

Coverage increased (+0.04%) to 88.502% when pulling 1d719ea on remove-crypto into 95683dd on master.

@jwerle
Copy link
Contributor

jwerle commented Aug 15, 2018

@holgerd77 anything holding this up? 🙃

Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, not sure about this. The aim of this PR is to remove crypto as a whole right? Do we only need to remove it where randomBytes is used?

@holgerd77
Copy link
Member

@jwerle I have not deep enough insights here to give comments on this.

@holgerd77
Copy link
Member

Rebased this.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will use the comment from @jwerle as a review and approve/merge.

@holgerd77 holgerd77 merged commit 5735026 into master Sep 24, 2018
@holgerd77 holgerd77 deleted the remove-crypto branch September 24, 2018 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants