-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: disabling most of the hardfork-specific tests #950
Conversation
8909f12
to
ffd1e04
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
@jochem-brouwer double-checking: what are the most important HFs to test here? We can keep to 2 or 3 for brevity. @holgerd77 After choosing the HFs, can I tweak the required status checks for |
I'd say the most important are |
.github/workflows/vm-pr.yml
Outdated
@@ -53,15 +53,15 @@ jobs: | |||
matrix: | |||
fork: [ | |||
'Berlin', | |||
'MuirGlacier', | |||
# 'MuirGlacier', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we also include MuirGlacier
since this is what currently runs on mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! the changes are in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, great!
I have updated the required checks according to the state and blockchain I have just changed. Closing and reopening PR to try to see the Required Checks change in effect. |
I would be careful with this, there are plenty of ways to break old HF code with lastest-fork-feature-adding PRs, we just had an example for this with the broken |
As promised, this PR disables most of the hardfork specific tests, to favor job concurrency.
It can be easily reverted, by un-commenting those lines.