-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small Release/README Fixes #949
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for the added consistency.
I made two code suggestions that are not blockers, so I am approving the changes here.
|
||
[![NPM Package][block-npm-badge]][block-npm-link] | ||
[![GitHub Issues][block-issues-badge]][block-issues-link] | ||
[![Actions Status][block-actions-badge]][block-actions-link] | ||
[![Code Coverage][block-coverage-badge]][block-coverage-link] | ||
[![Discord][discord-badge]][discord-link] | ||
|
||
Implements schema and functions related to Ethereum's block. | ||
| Implements schema and functions related to Ethereum's block. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice result! :)
Co-authored-by: Ev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
The new GitHub feature to batch suggestions into one commit is very cool! |
@ryanio oh yeah, that's indeed super-cool, otherwise having 10 commits for correcting 10 typos is purely insane. 😜 Thanks for integrating this and merging! |
This PR fixes some inconsistencies within the README files discovered while browsing through the repository after having done the
beta.2
releases.Changes are mostly header updates and headline hierarchy corrections, also some small rewrites.
The eventually somewhat unusual (or: not so commonly spotted) subtitle formatting is a table header without a body and renders like the following: