-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark ci fixes #840
Benchmark ci fixes #840
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Not sure about this, feel free to update, but have given this a |
741d84f
to
a26850e
Compare
…it tree ci: handling exit codes for cases where no changes were made to the git tree
a26850e
to
9cfa9f0
Compare
@holgerd77 thanks! @evertonfraga's commit was the fix needed, just had to also apply it to vm-pr.yml (in addition to vm-build.yml) so this should be ready for review and merge now! I also rebased on master. Sorry about the performance alerts, I'm hoping once this is running on master we'll get some normalization of the benchmark run times. If it's all over the place then I'll have to re-think the approach. |
39263e9
to
9cfa9f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I could make the stash
command simpler, but my tries led to syntax errors for the yaml parser. Maybe next iteration! :)
@evertonfraga nice work, thanks! 🙂 |
This PR:
git stash
before github-action-benchmark