Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: remove old fields consensus and finality #758

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Jun 2, 2020

As per #755 (comment), this PR removes old unused fields consensus and finality.

Please see this commit for a clean diff prior to rebuilding docs.

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #758 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   92.09%   91.99%   -0.10%     
==========================================
  Files          47       43       -4     
  Lines        3009     2985      -24     
  Branches      468      469       +1     
==========================================
- Hits         2771     2746      -25     
  Misses        144      144              
- Partials       94       95       +1     
Flag Coverage Δ
#account 94.11% <ø> (ø)
#block 88.09% <ø> (-0.28%) ⬇️
#blockchain 88.74% <ø> (-0.42%) ⬇️
#common 93.87% <ø> (-0.50%) ⬇️
#tx 94.02% <ø> (-0.14%) ⬇️
#vm 93.09% <ø> (ø)
Impacted Files Coverage Δ
packages/common/src/index.ts 93.87% <ø> (-0.25%) ⬇️
packages/blockchain/src/cache.ts 80.00% <0.00%> (-20.00%) ⬇️
packages/common/src/hardforks/index.ts
packages/tx/src/index.ts
packages/common/src/chains/index.ts
packages/common/src/genesisStates/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a818c84...40c0bed. Read the comment docs.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ryan, nice, looks good!

If you want to directly continue you can also remove the sharding and casper paramters for the HF files. 😁 These are a bit on the same level, modeled from another perspective with the outlook of an integrated sharding/casper/everything-in-one-place chain (I would say that we can/should remove sharding here as well, there might be some potential need for this in the future, but this is rather hypothetical and who know if this would fit into this structure. Likely rather not.)

@holgerd77 holgerd77 merged commit 61c3dca into master Jun 3, 2020
@holgerd77 holgerd77 deleted the common/remove-old-fields branch June 3, 2020 11:48
@ryanio
Copy link
Contributor Author

ryanio commented Jun 3, 2020

If you want to directly continue you can also remove the sharding and casper paramters for the HF files. 😁

sounds good, I'll do that now 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants