Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache calls to promisify present in hot paths #600

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Conversation

alcuadrado
Copy link
Member

This PR implements two performance optimizations. See #598 for more info.

@lgtm-com
Copy link

lgtm-com bot commented Sep 19, 2019

This pull request introduces 1 alert when merging 35b4b6c into 195bba7 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for digging deep and fixing this so quickly Patricio!

@s1na s1na merged commit 15dca7c into master Sep 20, 2019
@s1na s1na deleted the hot-paths-promisify branch September 20, 2019 08:53
@holgerd77
Copy link
Member

Just another 2 cents comment after merge: it would have been nice if there would be some comments on these changes in the code so that it gets more transparent for others what is actually happening here and why these changes have been introduced, otherwise there is the risk that this gets lost again.

Another thing, logically unrelated by topically related: it would of course be fabulous to have benchmarking in CI, also with a threshold to reject the build. Does something like this actually exist?

@alcuadrado
Copy link
Member Author

alcuadrado commented Sep 20, 2019

Just another 2 cents comment after merge: it would have been nice if there would be some comments on these changes in the code so that it gets more transparent for others what is actually happening here and why these changes have been introduced, otherwise there is the risk that this gets lost again.

Oh, this is a great idea! Will make a small PR with this.

Another thing, logically unrelated by topically related: it would of course be fabulous to have benchmarking in CI, also with a threshold to reject the build. Does something like this actually exist?

I'm not sure. Running performance tests on every push may be super slow.

I sometimes follow TypeScript issues, and they have a bot that runs them on demand. That could be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants