Migrate precompiles, opcodes, eei, message, txContext to typescript #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Phew. 😄 |
|
Ah, so this is actually ready for review? Misunderstood first. |
|
Just scrolled through for a first round, think this will be manageable for review. 😀😛 |
holgerd77
approved these changes
Apr 20, 2019
| throw new VmError(err) | ||
| } | ||
|
|
||
| const MASK_160 = new BN(1).shln(160).subn(1) | ||
| function addressToBuffer (address) { | ||
| function addressToBuffer (address: BN) { | ||
| return address.and(MASK_160).toArrayLike(Buffer, 'be', 20) | ||
| } |
| @@ -17,7 +31,7 @@ module.exports = class Message { | |||
| this.delegatecall = opts.delegatecall || false | |||
| } | |||
|
|
|||
| get codeAddress () { | |||
| get codeAddress (): Buffer { | |||
| return this._codeAddress ? this._codeAddress : this.to | |||
| } | |||
| } | |||
| fee: number; | ||
| dynamic: boolean; | ||
| isAsync: boolean; | ||
| } |
| @@ -192,5 +200,5 @@ module.exports = function (op, full, freeLogs) { | |||
| } | |||
| } | |||
|
|
|||
| return {name: opcode, opcode: op, fee: fee, dynamic: code[2], async: code[3]} | |||
| return { name: opcode, opcode: op, fee: fee, dynamic: code[2], isAsync: code[3] } | |||
| } | |||
| exception: 0, // 0 means VM fail (in this case because of OOG) | ||
| exceptionError: ERROR.OUT_OF_GAS | ||
| } | ||
| } |
There was a problem hiding this comment.
Really really nice to have these new precompile interfaces and to have this more systematically structured and wrapped like this.
| return: data, | ||
| exception: 1 | ||
| } | ||
| } |
| return: R.toArrayLike(Buffer, 'be', mLen.toNumber()), | ||
| exception: 1 | ||
| } | ||
| } |
| return: returnData, | ||
| exception: 1 | ||
| } | ||
| } |
| return: returnData, | ||
| exception: 1 | ||
| } | ||
| } |
| return: returnData, | ||
| exception: 1 | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy for now with precompiles, but the rest are still subject to change. E.g.
Message's constructor gets anopts: any, which doesn't utilize typescript's benefits.I also tried migrating
InterpreterandLoopbut realized halfway that they need some changes before they can be typed well.(To be merged into #479)