Trie: replace static methods #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottyPoi
added
PR state: needs review
type: refactor
package: mpt
breaking
target: master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving ahead with #3487
constructor methods:
Moved to
constructors.tsTrie.createcreateTrieTrie.createFromProofcreateTrieFromProofTrie.fromProofcreateTrieFromProofstatic proof methods
Moved to
proof/index.tsTrie.verifyProofverifyTrieProofTrie.verifyRangeProofverifyTrieRangeProof--
small refactor in
createTrieFromProofnew function
createTrieFromProofreplacesTrie.createFromProofand deprecated methodTrie.fromProofA small refactor was made, removing the optional parameter
shouldVerifyRootparameter, which defaulted tofalse. The new function will infer this intention by the presence of arootvalue passed into the (also optional)trieOptsparameter.