-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: revert some PrefixedHexString breaking changes #3427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Left a few suggestions and comments.
Co-authored-by: Scorbajio <[email protected]>
Co-authored-by: Scorbajio <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
This PR re-adds support for type
string
as an input type for some util helpers, to preserve backwards compatibility.I also realized that isHexPrefixed was redundant (we already had an internal helper that implements that behavior) so I removed it.