Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up access to deposit address in common #3411

Merged
merged 4 commits into from
May 8, 2024
Merged

Clean up access to deposit address in common #3411

merged 4 commits into from
May 8, 2024

Conversation

acolytec3
Copy link
Contributor

Small cleanup item for the depositContractAddress used in 6110 -

  • Adds a test that demonstrates how to set a custom depositContractAddress and access it from common
  • Revises how the requests module accesses the depositContractAddress parameter on common

g11tech
g11tech approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@acolytec3 acolytec3 merged commit 0e06ddf into master May 8, 2024
33 of 34 checks passed
@holgerd77 holgerd77 deleted the add-depositContractAddress-test branch May 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
package: common package: vm PR state: needs review type: maintenance type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acolytec3 @g11tech @holgerd77