Polygon amoy support #3380
Closed
Polygon amoy support #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parth2412
commented
Apr 27, 2024
Parth2412
commented
- Added support for polygon amoy testnet.
Signed-off-by: Parth2412 <[email protected]>
Signed-off-by: Parth2412 <[email protected]>
Signed-off-by: Parth2412 <[email protected]>
|
Covering Issue #3379 |
|
Please review: @acolytec3 @steveluscher @dbrock @Arachnid @axic |
Signed-off-by: Parth2412 <[email protected]>
|
@holgerd77 Please review |
acolytec3
reviewed
May 1, 2024
| @@ -98,6 +98,52 @@ describe('[Common]: Custom chains', () => { | |||
| } | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Did you make any substantial changes in this new test other than change the custom chain reference on line 106 to PolygonAmoy? I don't see anything obvious so not sure we need a duplicate of the test above with a different chain name.
acolytec3
reviewed
May 1, 2024
| @@ -364,6 +364,7 @@ The following L2 networks have been tested to work with `@ethereumjs/tx`, see us | |||
| | xDai Chain | `Common.xDaiChain` | [#1323](https://github.com/ethereumjs/ethereumjs-monorepo/issues/1323) | | |||
| | Optimistic Kovan | `Common.OptimisticKovan` | [#1554](https://github.com/ethereumjs/ethereumjs-monorepo/pull/1554) | | |||
| | Optimistic Ethereum | `Common.OptimisticEthereum` | [#1554](https://github.com/ethereumjs/ethereumjs-monorepo/pull/1554) | | |||
| | Polygon Amoy Testnet | `CustomChain.PolygonAmoy` | [#3379](https://github.com/ethereumjs/ethereumjs-monorepo/issues/3379) | | |||
There was a problem hiding this comment.
Did you test and confirm that transactions created with our libraries are accepted and included in Amoy blocks?
acolytec3
reviewed
May 1, 2024
|
@Parth2412 just checking in, are you able to address the review questions? |
|
Going to close for now as no follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.