monorepo: cleanup ts-ignore and ts-expect-error #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
approved these changes
Apr 22, 2024
| block.transactions = transactions | ||
|
|
||
| if (transactions.some((t) => t.supports(Capability.EIP1559FeeMarket))) { | ||
| // @ts-ignore overwrite read-only property | ||
| // @e read-only property |
There was a problem hiding this comment.
Won’t make it a blocker, but this and above seems like a leftover?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanups several instances where ts-ignore or ts-expect-errors was used, instead replacing them with less intrusive TypeScript solutions.
Notably, these TypeScript tags were very often used to ignore TS errors related to access of protected object properties. Instead, these properties can be accessed (without error) by the string literal.
Here's an example: