Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie API documentation updates #3267

Merged
merged 8 commits into from
Feb 2, 2024
Merged

Trie API documentation updates #3267

merged 8 commits into from
Feb 2, 2024

Conversation

scorbajio
Copy link
Contributor

This PR addresses issues mentioned in #3265.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (0ea97e7) 88.35% compared to head (e9f7ae1) 86.89%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.57% <ø> (?)
blockchain 91.60% <ø> (?)
client 84.65% <ø> (?)
common 98.25% <ø> (?)
devp2p 82.12% <ø> (?)
ethash ∅ <ø> (?)
evm 74.54% <ø> (?)
genesis 99.98% <ø> (?)
statemanager 75.86% <ø> (?)
trie 89.12% <94.54%> (?)
tx 95.89% <ø> (?)
util 89.13% <ø> (?)
vm 80.16% <ø> (?)
wallet 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 102f0da into master Feb 2, 2024
46 checks passed
@holgerd77 holgerd77 deleted the trie-api-doc-updates branch February 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trie: Proper Code Documentation for Proof Methods
2 participants